Possible fix for #505 #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the approximate solution I was thinking of - but it mat not be perfect - and would need validation under Apache 2.2 and Apache2.4, for code that does, and does not use the `connection->remote_ip` method. The deparsed code block doesn't not contain comments (so wouldn't flag commented-out code - which I think is correct). It may be that a link to a wiki page relating to the issue would be helpful to output - or alink to #214?
|
This looks OK to merge in. I will test it myself to check it has the intended behaviour. |
|
@jesusbagpuss I see what you mean by not being perfect. Unless you were really closely checking the Apache log file you would not spot this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the approximate solution I was thinking of - but it mat not be perfect - and would need validation under Apache 2.2 and Apache2.4, for code that does, and does not use the
connection->remote_ipmethod.The deparsed code block doesn't not contain comments (so wouldn't flag commented-out code - which I think is correct).
It may be that a link to a wiki page relating to the issue would be helpful to output - or alink to #214?