You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This line sets the "type" in the BibTex export to "unpub" for any type (thesis, article, etc.) if it finds the "unpublished" value in "ispublished" field:
"
I don't think that makes sense. A thesis might be "unpublished" but it is nevertheless still a "thesis" that is available in a repository. Furthermore, this breaks the import into Zotero, as there is no "unpublished" as an Item Type there.
The same thing happens with Reference Manager export, on this line:
Both ReferenceManager and BibTex would otherwise work for Zotero export if it wasn't for this unexpected issue with "unpublished":
I think I agree with your point. I think the best solution is changing the conditional statement that will only change the type (to unpublished or UNPB) if it has not already been changed by the fact that it is specific type. Although reading the BibTeX, this would technically be wrong. However, I guess this is where theory and the real world clash. Two things that could help:
Add a note field to indictate it is unpublished whilst keeping the original type (i.e. article, thesis, etc.).
Make this feature of not setting as unpublished confiigurable but enabled by default, i.e. future releases by default won't set unpublished if a specific type has already been set.
Hi @drn05r! Thank you so much for making this change. I just tested this with a default 3.4.3, and I see that the "unpublished" overrides the set item type, even though the option is set. I think that contradicts the intention of NOT overriding by default?
"Make this feature of not setting as unpublished confiigurable but enabled by default, i.e. future releases by default won't set unpublished if a specific type has already been set."?
This code: $publication_status_type_override = 1 unless EPrints::Utils::is_set( $publication_status_type_override );
So in other words, set it to override (ie., unpublished) by default, unless it is already set to 1 in config (which it is, by default).
So to get it to NOT override, I would have to set the config option to 0, right?
Yes. If there is no configuration option $c->{export}->{publication_status_type_override} then the variable $publication_status_type_override will be set to 1, (i.e. true). The only way for $publication_status_type_override to be false is if you explicitly set $c->{export}->{publication_status_type_override} = 0;
This line sets the "type" in the BibTex export to "unpub" for any type (thesis, article, etc.) if it finds the "unpublished" value in "ispublished" field:
"
eprints3.4/flavours/pub_lib/plugins/EPrints/Plugin/Export/BibTeX.pm
Line 155 in d92e317
I don't think that makes sense. A thesis might be "unpublished" but it is nevertheless still a "thesis" that is available in a repository. Furthermore, this breaks the import into Zotero, as there is no "unpublished" as an Item Type there.
The same thing happens with Reference Manager export, on this line:
Both ReferenceManager and BibTex would otherwise work for Zotero export if it wasn't for this unexpected issue with "unpublished":
eprints3.4/flavours/pub_lib/plugins/EPrints/Plugin/Export/RIS.pm
Line 358 in d92e317
Are we sure that this use of "unpublished" as an item type is correct?
The text was updated successfully, but these errors were encountered: