Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent (once) live eprint items from being removed #145

Closed
drn05r opened this issue Apr 15, 2021 · 3 comments
Closed

Prevent (once) live eprint items from being removed #145

drn05r opened this issue Apr 15, 2021 · 3 comments
Assignees
@drn05r
Labels
enhancement New feature or request
Milestone
3.4.3

Comments

@drn05r
Copy link
Contributor

drn05r commented Apr 15, 2021

Once an item is live it should not be removable (only retireable). If you remove an item that have been live even if it has previously been retired it can effect third-party application trying to sync metadata user OAI-PMH. It may also have impact on other aspects of EPrints, especially involving export.

It maybe should still be possible to remove (once) live items but this should be very difficult. E.g. require a permission that even admin users do not have by default. Also when an admin with this advanced permission tries to remove an item (once) live they should receive a much more strict warning about the consequences of removing such an item.
@drn05r drn05r added the enhancement New feature or request label Apr 15, 2021
@drn05r drn05r added this to the 3.4.4 milestone Apr 15, 2021
@drn05r drn05r self-assigned this Apr 15, 2021
@jesusbagpuss
Copy link
Contributor

I think an additional priv that works alongside existing ones might be best, as it could be re-used in:

  • EPrints::Plugin::Screen::EPrint::Remove
  • EPrints::Plugin::Screen::EPrint::RemoveWithEmail

The EPrints::Plugin::Screen::EPrint::RequestRemoval screen could also be updated to indicate that an item may be removed or moved to deletion.

@drn05r
Copy link
Contributor Author

drn05r commented Apr 25, 2021

RequestRemoval already includes in its intro "Please note that we strongly discourage removal of items from the repository". So I don't think there is a need to add anything further to this page.

drn05r added a commit that referenced this issue Apr 25, 2021
@drn05r
Addresses #145 by preventing (once) live items being destroyed, witho…
c98c6b2 
…ut special permission.
@drn05r
Copy link
Contributor Author

drn05r commented Apr 25, 2021

I think my latest commit meets the requirements discussed. I have added info about the new permission being required to explain why "Destroy Item" will not be an option for some items on the review page, if they have previously been live. However, I cannot think of anywhere appropriate to make repository admins more generally aware of this and how they might re-enable such a permission. I can already imagine frantic emails on the tech list saying: "I cannot remove item X that has confidential information in it."

@drn05r drn05r modified the milestones: 3.4.4, 3.4.3 Apr 27, 2021
@drn05r drn05r closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drn05r drn05r

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.4.3
Development

No branches or pull requests
2 participants
@jesusbagpuss @drn05r