Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the timestamp of the inc file for auto JavaScript/CSS client-side caching #274

Closed
drn05r opened this issue Jan 6, 2023 · 0 comments
Closed

Include the timestamp of the inc file for auto JavaScript/CSS client-side caching #274

drn05r opened this issue Jan 6, 2023 · 0 comments
Assignees
@drn05r
Labels
bug Something isn't working
Milestone
3.4.5

Comments

@drn05r
Copy link
Contributor

drn05r commented Jan 6, 2023

At present the timestamp that is added at the end of the links for JavaScript/CSS auto files that appear in the <head> of each page is determined by the last modified time of any Javascript/CSS file that makes up the respective auto-generated file. However, the files included could change without any of them being modified if the inc file is edited to add or remove an ingredient. Therefore, the inc file's last modified time should be incorporated into the timestamps generated for the auto-generated JavaScript/CSS links.

N.B. There is also the possibility that an auto-generated file will change because a JavaScript file is removed. However, as there will be no last modified time to check it is impossible to determine that what the auto-generated would have changed. However, this is a sufficient edge-case and easily fixed by a hard refresh of the browser. There may be a solution but it is certainly not to update the timestamp every time a page is loaded.
@drn05r drn05r added the bug Something isn't working label Jan 6, 2023
@drn05r drn05r added this to the 3.4.5 milestone Jan 6, 2023
@drn05r drn05r self-assigned this Jan 6, 2023
@drn05r drn05r closed this as completed in 62c0f6c Jan 12, 2023
drn05r added a commit that referenced this issue Jan 13, 2023
@drn05r
Fixes issues with rewritten auto_timestamp function (#274)
7e5b83b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drn05r drn05r

Labels
bug Something isn't working
Projects
None yet
Milestone
3.4.5
Development

No branches or pull requests
1 participant
@drn05r