Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from orcid.org : contributors with no ORCID ID #27

Closed
cziaarm opened this issue Jan 3, 2019 · 2 comments · Fixed by #28
Closed

Import from orcid.org : contributors with no ORCID ID #27

cziaarm opened this issue Jan 3, 2019 · 2 comments · Fixed by #28

Comments

@cziaarm
Copy link
Contributor

cziaarm commented Jan 3, 2019

Hello,

https://github.com/eprints/orcid_support_advance/blob/master/lib/plugins/EPrints/Plugin/Screen/ImportFromOrcid.pm#L775

Precludes the ingest of contributors (eg co-authors) that do not have an ORCID. Would it be OK if name only was ingested for non-ORCID co-authors? If so I'll put together a suitable PR

Rory
@cziaarm cziaarm changed the title Contributors with no ORCID ID Import from orcid.org : contributors with no ORCID ID Jan 3, 2019
@zuphilip
Copy link
Contributor

zuphilip commented Jan 4, 2019

Sounds good for me. CC @wfyson Maybe you can then also fix the spacing problems in the following lines (tabs vs. spaces) to make the code easier to read.

@wfyson
Copy link
Collaborator

wfyson commented Jan 4, 2019

Yeah that all sounds sensible to me!

@cziaarm cziaarm mentioned this issue Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

import improvements eprintsug/orcid_support_advance
3 participants
@cziaarm @wfyson @zuphilip