New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOT-7230] Implement a HINT parameter as part of the HANA plug-in #4064
Conversation
This change adds a new "SELECT Hint" parameter to the HANA JDBC plugin. "SELECT Hint"s are appended to SELECT queries, embedded in the string WITH HINT( <SELECT Hints> ) Setting SELECT Hints enables a user to configure HANA specific query hints that will be considered during query plan generation.
String.class, | ||
"Comma-separated list of hints that will be applied to SELECT queries, e.g. ESTIMATION_SAPLES(0), NO_HASH_JOIN", | ||
false, | ||
null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the documentation it says the fifth parameter is for example input. Should be put ESTIMATION_SAMPLES(0) and NO_HASH_JOIN in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially did this, but then realized that the GeoServer connection dialog uses the sample to pre-populate the textbox. Hence, I reverted it to null.
new Param( | ||
"SELECT Hints", | ||
String.class, | ||
"Comma-separated list of hints that will be applied to SELECT queries, e.g. ESTIMATION_SAPLES(0), NO_HASH_JOIN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an M missing in ESTIMATION_SAPLES(0)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fixed it.
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-28.x 28.x
# Navigate to the new working tree
cd .worktrees/backport-28.x
# Create a new branch
git switch --create backport-4064-to-28.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 0f98e73346b98a67dd2e0acf596b79982eae7471,02e8192e63c9b71e8fd4ca013429d8ffe4c4474c,ffc51f5c06535fef254993138cf336975774d308
# Push it to GitHub
git push --set-upstream origin backport-4064-to-28.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-28.x Then, create a pull request where the |
This pull request adds a new "SELECT Hint" parameter to the HANA JDBC plugin.
SELECT Hint
s are appended to SELECT queries, embedded in the stringSetting
SELECT Hint
s enables a user to configure HANA specific query hints that will be considered during query plan generation.Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOT-XYZW] Title of the Jira ticket
.