Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration of "fast" games is unnecessarily complicated and error-prone #1084

Closed
jecollins opened this issue Apr 30, 2021 · 3 comments
Closed

Configuration of "fast" games is unnecessarily complicated and error-prone #1084

jecollins opened this issue Apr 30, 2021 · 3 comments
Labels
Bug Competition Control

Comments

@jecollins
Copy link
Member

When running a server and a few agents in a local environment on a fast machine, it should be possible to significantly speed up the simulation. However, there is a strong, undocumented interaction between the time allocated to a timeslot and the time allocated to agents in each timeslot. Shortening the timeslot without also managing the agent allocation causes the server to blow up. Also, the configuration of the agent window is expressed in integer seconds, which severely limits the fine-tuning of this relationship.
@jecollins jecollins added the Bug label May 10, 2021
@jecollins
Copy link
Member Author

It's worse than being complicated, it's wrong. The server can change the rate (in CompetiionControlService.setTimeParameters() without informing the broker, so the two no longer agree on the time.

jecollins added a commit that referenced this issue May 15, 2021
@jecollins
#1084 - use ratio for agent window, allow non-integer timeslot length…
2471ff0 
…, remove agent-window config
@jecollins
Copy link
Member Author

Turns out both the Rate and the timeslot length in msec need to be integers. So we have to find values for both that are factors of the sim-world timeslot duration of 3600000 msec. Fortunately that number has many factors.

jecollins added a commit that referenced this issue May 19, 2021
@jecollins
#1084 - move rate adjustment to Competition where it belongs
4f54f18
@jecollins
Copy link
Member Author

jecollins commented May 19, 2021 •
edited

Tested down to 0.7 sec timeslots, saw one pause and no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Competition Control
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jecollins