Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presumed OSI website typo replicated in NTP #1653

Closed
richardfontana opened this issue Oct 1, 2022 · 1 comment · Fixed by #1764
Closed

Presumed OSI website typo replicated in NTP #1653

richardfontana opened this issue Oct 1, 2022 · 1 comment · Fixed by #1764
Labels
XML markup change potential change or addition to XML markup in license
Milestone
3.20

Comments

@richardfontana
Copy link
Contributor

The XML for NTP has

        <alt match=".+" name="TMname">(TrademarkedName)</alt> makes no representations about the suitability
        this software for any purpose. It is provided "as is" without express or implied warranty.

This copies the version on opensource.org (https://opensource.org/licenses/NTP) but at least some real-world uses of this license type have "suitability of this software" instead of the (ungrammatical/unidiomatic) "suitability this software".

Example: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=readline/readline/support/install.sh;h=0cac004e6dce38456fc54e6e7dac614caa662e12;hb=HEAD

Common sense, and the now well-established history of faulty OSI website replications of certain license texts, and the fact that this is a legacy license type predating the founding of the OSI, all suggest that the "suitability this software" version is erroneous (however I did not attempt to search for any real-world use of that version on software).
@jlovejoy jlovejoy added new license/exception request XML markup change potential change or addition to XML markup in license and removed new license/exception request labels Oct 4, 2022
@swinslow
Copy link
Member

I'd suggest we edit to add "of" as an <optional> text section. That way, it will continue to match for both the grammatical version and the OSI website version.

@swinslow swinslow added this to the 3.20 milestone Dec 27, 2022
@swinslow swinslow mentioned this issue Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
XML markup change potential change or addition to XML markup in license
Projects
None yet
Milestone
3.20
Development

Successfully merging a pull request may close this issue.

NTP: Add optional 'of' text swinslow/license-list-XML
3 participants
@swinslow @richardfontana @jlovejoy