drivers: sensor: mcp9600: Added driver and sample for mcp9600 #31082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
requested changes
Jan 5, 2021
github-actions
bot
added
area: Devicetree
area: Devicetree Binding
Added driver and sample for mcp9600 microchip I2C thermocouple amplifier. Tested on frdm_kw41z and nrf52850dk. Fixed multiple comments on the code. Tested fixes Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
editing error on readme no newline at end Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
MaureenHelm
requested changes
Jan 6, 2021
pabigot
requested changes
Jan 7, 2021
|
Also: squash the second commit which fixes a whitespace issue diagnosed in the first commit. Unless @MaureenHelm wants the sample in a separate commit from the driver as with #31064; that's not an expectation I have.
No, put both commits in the same PR, driver first, then sample. |
Split driver and sample in to seperate commits. This is the entire driver functionality to read the temperature of a K type thermocouple. Additional code will be needed if a different type is used or to configure the alarm trigger functionality. On branch sensor_mcp9600 Your branch is up to date with 'origin/sensor_mcp9600'. Changes to be committed: modified: drivers/sensor/CMakeLists.txt modified: drivers/sensor/Kconfig modified: drivers/sensor/mcp9600/CMakeLists.txt modified: drivers/sensor/mcp9600/Kconfig modified: drivers/sensor/mcp9600/mcp9600.c modified: drivers/sensor/mcp9600/mcp9600.h modified: dts/bindings/sensor/microchip,mcp9600.yaml Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
Sample code for using the mcp9600 driver. Sample only commit. Signed-off-by: Steven Riedl <steve@serconsultingllc.com> On branch sensor_mcp9600 Your branch is up to date with 'origin/sensor_mcp9600'. Changes to be committed: modified: samples/sensor/mcp9600/CMakeLists.txt modified: samples/sensor/mcp9600/README.rst deleted: samples/sensor/mcp9600/boards/nrf52840dongle_nrf52840.overlay modified: samples/sensor/mcp9600/prj.conf modified: samples/sensor/mcp9600/sample.yaml modified: samples/sensor/mcp9600/src/main.c
copy paste error included another driver I am working on that will be in a later contribution. deleted offending lines. On branch sensor_mcp9600 Your branch is up to date with 'origin/sensor_mcp9600'. Changes to be committed: modified: drivers/sensor/CMakeLists.txt modified: drivers/sensor/Kconfig Signed-off-by: Steven Riedl <steve@serconsultingllc.com>
|
Don't have time to finish this right now, will probably resubmit later, with proper multi-device support |
|
wanted to close on last comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added driver and sample for mcp9600 microchip I2C thermocouple
amplifier. Tested on frdm_kw41z and nrf52850dk.
Signed-off-by: Steven Riedl steve@serconsultingllc.com