This project is mirrored from https://*****@gitlab.com/koha-community/Koha.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
- Feb 08, 2023
-
-
joubu authored
See comment 34 and https://tree.taiga.io/project/joubu-koha-erm/us/127 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
This patch adds a new target to the Makefile which gets called as the first step of the "all" target. This means that CSS and JS files get compiled every time "make" is called. (Note: Since the "install" target depends on "all", it will be re-run at install time.) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
This patch adds a trivial perl wrapper around the yarn build and calls it from Makefile.PL. I 'think' this is all we need to get packaging, dev and standard installs happy with the lack of our compiled files in source. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
joubu authored
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
joubu authored
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
joubu authored
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
joubu authored
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
joubu authored
We had: yarn css # Build staff css yarn css --view opac # Build OPAC css yarn build # Nothing, was broken yarn watch # Nothing, was broken yarn build_js # Build JS/Vue yarn watch_js # Watch JS/Vue This patch is suggesting to have something more consistent: yarn css:build # Build CSS for OPAC and staff (dev) yarn css:build:prod # Build CSS for OPAC and staff (prod) yarn css:watch # Watch CSS for OPAC and staff (dev) yarn js:build # Build JS (dev) yarn js:build:prod # Build JS (prod) yarn js:watch # Watch JS (dev) yarn build # Same as css:build and js:build (dev) yarn build:prod # Same as css:build:prod and js:build:prod (prod) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
joubu authored
They are not used. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
-
- Feb 07, 2023
-
-
This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
In Suggestions management, in the table displaying all suggestions, add a column to display suggester category. This way, it is possible for example for the librarian managing suggestions rather to prioritize suggestions coming from teachers than those coming from students. TEST : 1. Apply the patch. 2. Acquisition > Suggestions. 3. There is a new column 'Suggester category'. It can be displayed/hidden. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This makes sure that the descriptions in the pull-downs always match for selected/unselected. This is not only for consistency, but will also ease translations as simple things like an additional space will create a new string to translate. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
'Script of title' values => e - b/c/d/e/f/g/h i - d/e j - f/g l - f n - b/c o - a p - a 'Translitteral code' values => 'g' and 'h' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This makes sure that the focus is on the first field of the form when adding a new currency. To test: * Go to administration > currencies * Add a new currency * Verify the focus is not on the form * Apply patch * Repeat, verify the focus is now on the first input "currency" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Tomas Cohen Arazi authored
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch updates three serials templates to replace tab markup with the use of WRAPPERs. To test requires more data than will be found in the sample data. You need at least one subscription with issues spanning more than one year. I suggest creating a new subscription which starts in December, then receive one issue from December and one in January. Apply the patch and go to Serials. - Perform a subscription search. - On the search results page there should be two tabs: "Open" and "Closed." These tabs should work correctly. - Open the detail view of one of your subscriptions. - You should see at least four tabs: "Information," "Planning," "Issues," and "Summary." - In some cases an "Acquisition details" tab will also appear. To test this you must go to Acquisitions and add an order to a basket by choosing "From a subscription" option. - Click "Serial collection" in the left-hand sidebar. - There should be tabs for each year of subscription issues in your collection. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the invoices page. To test you must have at least one open invoice and one closed invoice. - Go to Acquisitions -> Invoices. - You should see two tabs, "Open invoices" and "Closed invoices." - The tabs should look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the basket groups page. To test you must have at least one active vendor, one or more closed baskets under that vendor, and at least one basket group containing a closed basket. Apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should see two tabs, "Open" and "Closed." The tabs should look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the item circulation alerts page. To test, apply the patch and go to Administration -> Item circulation alerts. There should be two tabs, "Checkout" and "Check-in" which work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the library transfer limits page. To test, apply the patch and go to Administration -> Library transfer limits. It should look the same as before and all tabs should function correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch implements the proposed system for building tabs on the About page. To test, apply the patch and view the About page. It should look the same as before and all tabs should function correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
The module Log::Log4perl::Appender::Screen is attempting to change binmode during unit tests for SIPServer and is failing because of our tie in SIPServer.pm for reasons unknown. This patch implements the perltie method TIEHANDLE which allows the binmode to be handled in the C4::SIP::Trapper package. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
-
This patch follows the markup of the staff interface catalog results XSLT to make authors in OPAC search results clickable. The patch also makes some minor CSS changes so that title and author links are not too crowded together. To test, apply the patch and rebuild the OPAC CSS. - Perform a catalog search in the OPAC which will return multiple results. - In the search results, each author in each search result should be a separate clickable link. - The margins around the result title and authors should be comfortable. - Confirm that each link takes you to the correct author search. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
To test: 1. Have some records that have these 245 fields: -Title 245$a -Subtitle 245$b -Medium 245$h -Part number 245$n -Part name 245$p Note: IN KTD I have to run batchRebuildBiblioTables.pl -c 2. Apply patch and do an item search that will turn up items with the 245 fields lists above 3. Notice that those subfields are now included in the title column. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This param in the dropdown is meant to signify no change, distinct from "" when means to set to default. In rebasing this condition was lost, this patch restores undef of the variable to avoid setting framework to an invalid value To test: 1 - Stage a record with a match (export and import a record) 2 - Attempt to import and overlay with option 'When replacing records use this framework:' 'Keep original framework' 3 - It fails, logs note 'value too long for field frameworkcode' 4 - Apply this patch 5 - Try again, it succeeds - framework is not changed Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This patch allows for selection of framework to use when overlaying records - by default it is set to keep the initial framework To test: 1 - Create some records using one framework 2 - Export the records 3 - Edit the records to add fields not in original framework 4 - Stage records using a rule that will find matches 5 - Import 6 - Note records contain new fields on display, but they are lost on edit 7 - Apply patch 8 - Stage records again 9 - Select a framework that contains the new fields on import 10 - Import records 11 - Note records now use selected framework and are displayed/edited correctly Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Most other administration pages (those that don't have specific searches) are set by default on system preferences search. Test plan: Go to admin > Curbside pickup Confirm that the syspref search is displayed in the header Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This changes all occurences of "librarian interface" to the correct term "staff interface" To test: * Create a new Page * Verify that the pull down for location has "librarian interface" * Save your page * Verify that the list of existing pages has "Librarian interface" as label for the link * Verify that when you hover over on those links the titles read "librarian interface" as well * Apply patch * All those should read correctly now. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
The tags tool was missing the toolbar on the left side. With the filters, this patch adds the toolbar below, like we do on other pages like HTML customizations. To test: * Go to Tools > Tags * Verify no toolbar * Apply patch * Verify toolbar is now present * Compare to other tool pages * Sign off :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-
Fixes the lines for old_reserves.item_level_hold and reserves.item_level_hold comments to read 'hold' instead of 'hpld' To test: * The easiest way to verify this change is by looking at the patch itself Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
-